Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Terra2NCBI] Force collection_date to be a string #658

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

cimendes
Copy link
Member

This PR closes #

🗑️ This dev branch should be deleted after merging to main.

🧠 Summary

⚡ Impacted Workflows/Tasks

This PR may lead to different results in pre-existing outputs: Yes/No

This PR uses an element that could cause duplicate runs to have different results: Yes/No

🛠️ Changes

⚙️ Algorithm

➡️ Inputs

⬅️ Outputs

🧪 Testing

Suggested Scenarios for Reviewer to Test

🔬 Final Developer Checklist

  • The workflow/task has been tested and results, including file contents, are as anticipated
  • The CI/CD has been adjusted and tests are passing (Theiagen developers)
  • Code changes follow the style guide
  • Documentation and/or workflow diagrams have been updated if applicable (Theiagen developers only)

🎯 Reviewer Checklist

  • All changed results have been confirmed
  • You have tested the PR appropriately (see the testing guide for more information)
  • All code adheres to the style guide
  • MD5 sums have been updated
  • The PR author has addressed all comments
  • The documentation has been updated

@Michal-Babins Michal-Babins self-assigned this Nov 5, 2024
@sage-wright sage-wright closed this Nov 7, 2024
@sage-wright sage-wright deleted the im-terra2ncbi-collectiondate-dev branch November 7, 2024 20:18
@fraser-combe fraser-combe restored the im-terra2ncbi-collectiondate-dev branch November 7, 2024 20:28
@fraser-combe fraser-combe reopened this Nov 7, 2024
@sage-wright sage-wright marked this pull request as ready for review November 19, 2024 17:21
@sage-wright sage-wright requested a review from a team as a code owner November 19, 2024 17:21
@sage-wright sage-wright merged commit 2bf8822 into main Nov 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants